Code

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6719 closed (fixed)

syncdb: Better error message if installing custom sql failed

Reported by: guettli Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This is a small patch to improve the output if installing custom sql failed.
If verbosity>=2 the traceback gets display. Maybe this should even be if verbosity>=1.

If verbosity>=2 a message 'No custom sql for ...' get displayed.

A newline at the end of "Failed to install custom SQL for %s.%s model: %s" was missing, too.

Attachments (1)

syncdb_better_error_messages.diff (1.5 KB) - added by guettli 6 years ago.
Uses option '--traceback' now.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by guettli

  • Cc hv@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 6 years ago by jacob

  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Design decision needed

A better approach would be to make this work with the --traceback added some time back. That would be consistent with other things which suppress tracebacks (like fixture loading).

Changed 6 years ago by guettli

Uses option '--traceback' now.

comment:3 Changed 6 years ago by russellm

  • Needs documentation set
  • Patch needs improvement unset
  • Triage Stage changed from Design decision needed to Ready for checkin

Needs documentation of the new option, but that isn't much effort, so I'm promoting to ready for checkin.

comment:4 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [7704]) Fixed #6719 -- Added a --traceback option to syncdb to provide a stack trace when custom SQL loading fails. Also added documentation for the --traceback option. Thanks to guettli for the patch.

comment:5 Changed 6 years ago by guettli

  • Cc hv@… removed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.