Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6719 closed (fixed)

syncdb: Better error message if installing custom sql failed

Reported by: Thomas Güttler Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


This is a small patch to improve the output if installing custom sql failed.
If verbosity>=2 the traceback gets display. Maybe this should even be if verbosity>=1.

If verbosity>=2 a message 'No custom sql for ...' get displayed.

A newline at the end of "Failed to install custom SQL for %s.%s model: %s" was missing, too.

Attachments (1)

syncdb_better_error_messages.diff (1.5 KB) - added by Thomas Güttler 11 years ago.
Uses option '--traceback' now.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by Thomas Güttler

Cc: hv@… added

comment:2 Changed 11 years ago by Jacob

Patch needs improvement: set
Triage Stage: UnreviewedDesign decision needed

A better approach would be to make this work with the --traceback added some time back. That would be consistent with other things which suppress tracebacks (like fixture loading).

Changed 11 years ago by Thomas Güttler

Uses option '--traceback' now.

comment:3 Changed 11 years ago by Russell Keith-Magee

Needs documentation: set
Patch needs improvement: unset
Triage Stage: Design decision neededReady for checkin

Needs documentation of the new option, but that isn't much effort, so I'm promoting to ready for checkin.

comment:4 Changed 11 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [7704]) Fixed #6719 -- Added a --traceback option to syncdb to provide a stack trace when custom SQL loading fails. Also added documentation for the --traceback option. Thanks to guettli for the patch.

comment:5 Changed 11 years ago by Thomas Güttler

Cc: hv@… removed
Note: See TracTickets for help on using tickets.
Back to Top