Opened 8 years ago

Closed 8 years ago

#6606 closed (invalid)

django.newforms.form.BoundField.as_widget doesn't merge widget.attrs

Reported by: moep Owned by: moep
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django.newforms.form.BoundField.as_widget doesn't merge widget.attrs

wich means if you specify additional attr in Field.widget_attrs they never make it into Widget.render

I could write a patch but I'm not quite sure if as_widget is the right place to do it. The return value
of widget.attrs gets set to Field.widget_attrs so widget.render could do the merging as well, but then
you would have to change almost every widget.render function.

Change History (2)

comment:1 Changed 8 years ago by moep

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to moep
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 8 years ago by moep

  • Resolution set to invalid
  • Status changed from assigned to closed

merging is done Widget.build_attrs ... i might have been a bit to overhasty :)

Note: See TracTickets for help on using tickets.
Back to Top