Opened 9 years ago

Closed 9 years ago

#6520 closed (wontfix)

NullBooleanSelect shouldn't use 'Unknown'

Reported by: Peter Baumgartner Owned by: nobody
Component: Forms Version: master
Severity: Keywords: nullbooleanselect nullbooleanfield unknown
Cc: sgt.hulka@… Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

NullBooleanSelect should use u'---------' instead of ugettext('Unknown').

This matches the default empty_label for ModelChoiceField so newforms have a more uniform look. Unknown is not a synonym for Null. '---------' or are better text representations of Null.

Attachments (1)

nullbooleanselect_patch.diff (719 bytes) - added by Peter Baumgartner 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Peter Baumgartner

comment:1 Changed 9 years ago by Peter Baumgartner

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

WikiFormatting got me. That should say '---------' or '' are better text representations of Null.

comment:2 Changed 9 years ago by Chris Beaven

Triage Stage: UnreviewedDesign decision needed

Potentially... the only problem is that '-------' might imply that you need to change it.

comment:3 Changed 9 years ago by Malcolm Tredinnick

Resolution: wontfix
Status: newclosed

I think this is a bit of a judgement call, but what we've got at the moment feels a bit clearer. "Unknown" is precisely what NULL means at the database level, so there's no semantic mismatch there.

Because of the backwards incompatibility this would introduce and the fact that the current text makes it really clear there are three choices here, not just two plus a "you haven't set this yet" option, let's leave it as it is.

Note: See TracTickets for help on using tickets.
Back to Top