Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#645 closed enhancement (fixed)

[patch] Replace _module_-prefix and module_constants with "class MODULE"

Reported by: Sune Kirkeby <sune.kirkeby@…> Owned by: Adrian Holovaty
Component: Core (Other) Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


As discussed in the thread Get rid of model modules? on django-devel, it
would be nice to get rid of the _module_-prefix and module_constants, and have module-level constants and functions
in a class MODULE ala class META.

Attachments (1)

class-module.patch (27.2 KB) - added by Sune Kirkeby <sune.kirkeby@…> 13 years ago.

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by Sune Kirkeby <sune.kirkeby@…>

Attachment: class-module.patch added

comment:1 Changed 13 years ago by Sune Kirkeby <sune.kirkeby@…>

Component: Admin interfaceCore framework

The patch is here now :) It removes support for the _module_-prefix and module_constants,
I don't know if we want to keep them for a short while? That should be a pretty simple fix.

comment:2 Changed 13 years ago by Adrian Holovaty

Status: newassigned

Thanks for the reminder on this, Sune! And for the patch, of course...

comment:3 Changed 13 years ago by rjwittams

I had planned to do this, subclassing, and removing core fields in a shortish branch after new-admin merges, to lump all the model changes into one go. Thoughts?

comment:4 Changed 13 years ago by Adrian Holovaty

Resolution: fixed
Status: assignedclosed

This has been fixed in magic-removal branch, via the managers concept. See RemovingTheMagic.

Note: See TracTickets for help on using tickets.
Back to Top