Code

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#645 closed enhancement (fixed)

[patch] Replace _module_-prefix and module_constants with "class MODULE"

Reported by: Sune Kirkeby <sune.kirkeby@…> Owned by: adrian
Component: Core (Other) Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

As discussed in the thread Get rid of model modules? on django-devel, it
would be nice to get rid of the _module_-prefix and module_constants, and have module-level constants and functions
in a class MODULE ala class META.

Attachments (1)

class-module.patch (27.2 KB) - added by Sune Kirkeby <sune.kirkeby@…> 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Sune Kirkeby <sune.kirkeby@…>

comment:1 Changed 9 years ago by Sune Kirkeby <sune.kirkeby@…>

  • Component changed from Admin interface to Core framework

The patch is here now :) It removes support for the _module_-prefix and module_constants,
I don't know if we want to keep them for a short while? That should be a pretty simple fix.

comment:2 Changed 9 years ago by adrian

  • Status changed from new to assigned

Thanks for the reminder on this, Sune! And for the patch, of course...

comment:3 Changed 9 years ago by rjwittams

I had planned to do this, subclassing, and removing core fields in a shortish branch after new-admin merges, to lump all the model changes into one go. Thoughts?

comment:4 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from assigned to closed

This has been fixed in magic-removal branch, via the managers concept. See RemovingTheMagic.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.