@permission_required / _CheckLogin attempt to authenticate authenticated users rather saying permission denied.
|Reported by:||greencm||Owned by:||nobody|
|Cc:||Triage Stage:||Design decision needed|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
In developing django_cas, I would like it to be a drop-in augmentation for contrib.auth. CAS is essentially designed to have a separate server provide SSO for authentication data rather than checking a local password store.
The code we currently have works great for everything but the default contrib.auth.decorators.
@permission_required is essentially two checks:
1) Check they are authenticated
2) Check they have the right permissions
If this fails, direct the user to the login page.
In the CAS world (and presumably other similar architectures), directing the user back to the login url pushes them to the SSO server, the login server says the user is authenticated, directs them back to the original url (decorated by @permission_required), and then back to the SSO server in an infinite loop.
I would like to change the semantics of _CheckLogin to redirect only unauthenticated users to the login page and provide an HttpResponseForbidden error otherwise.
Change History (5)
Changed 6 years ago by greencm
comment:1 Changed 6 years ago by greencm
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
comment:2 Changed 6 years ago by Simon Greenhill <dev@…>
- Triage Stage changed from Unreviewed to Design decision needed