[patch]ifequal, filter and hardcoded-string doesn't work

[philipp@…]

Hi, I just experienced the following problem:

Let:

>>> url = "/home/test/"
>>> urlparts = url.trim("/").split("/")

['home', 'test']

In the template I have:

{% ifequal urlparts|first "home" %}test1{% endifequal %}
{% ifequal urlparts|first home %}test2{% endifequal %}

Only the "test2" gets shown.

[Thejaswi Puthraya]

The problem with ifequal is that it accepts only variables and doesn't allow any filters. So the urlparts|first variable is not resolved. In the second case (mentioned in the ticket) when home (or any values say abc) is given, this variable too gets resolved as None (because it is neither a Float, Integer or String) in the IfEqual Node and hence the equality case arises.

I have added patches by replacing the Variable with a FilterExpression. Even if a plain Variable is given it gets resolved without any problems. I shall add a couple of tests very soon.

[Thejaswi Puthraya]

patch and tests

[Thejaswi Puthraya]

This ticket looks very similar to #5756. But that ticket includes nodes like Cycle Node and Ifchanged Node. Since making such a big change would require a design decision, I have patched only for the Ifequal node.

[Johannes Dollinger]

This would be fixed by the refactoring proposed in #7806.

[Malcolm Tredinnick]

(In [10119]) Fixed #5756, #6296 -- Most template tags can now handle filters in arguments.

Most of the hard work for this was done by akaihola.

There are still possibly some problems with the i18n template tags,
since they are written quite differently and a few other bug fixes have
to made before they can be fixed.