Code

Opened 6 years ago

Closed 6 years ago

#6100 closed (fixed)

newforms-admin: popup won't be dismissed when adding

Reported by: oggie_rob Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: davidgrant@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

When you add a related field via newforms-admin, the popped up window isn't dismissed properly because of a javascript error. This is due to the value being passed into the html_unescape() function - it is an integer but the function is expecting a string.

Attachments (2)

6100.diff (596 bytes) - added by oggie_rob 6 years ago.
one-liner fix
6100.2.diff (979 bytes) - added by gwilson 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by oggie_rob

one-liner fix

comment:1 Changed 6 years ago by Simon G <dev@…>

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 6 years ago by anonymous

  • Version changed from SVN to newforms-admin

comment:3 Changed 6 years ago by brosner

Marked #6104 as a duplicate.

comment:4 Changed 6 years ago by gwilson

[6691] did not get merged correctly to newforms-admin.

Changed 6 years ago by gwilson

comment:5 Changed 6 years ago by jkocherhans

Any reason you haven't committed/closed this Gary?

comment:6 Changed 6 years ago by gwilson

I don't have the permissions to commit to newforms-admin.

comment:7 Changed 6 years ago by brosner

  • Keywords nfa-blocker added

I have also come across this problem. This needs to be included before the merge of newforms-admin.

comment:8 Changed 6 years ago by dgrant

  • Cc davidgrant@… added

When I was using newforms-admin at the beginning of January I didn't see this bug but now I do for some reason.

comment:9 Changed 6 years ago by Alex

  • Component changed from Uncategorized to Admin interface

comment:10 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [7194]) newforms-admin: Fixed #6100 -- Related field popup window now closes properly after saving. Thanks oggie_rob and Gary Wilson.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.