Opened 18 years ago

Closed 18 years ago

#6100 closed (fixed)

newforms-admin: popup won't be dismissed when adding

Reported by: oggie_rob Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: davidgrant@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When you add a related field via newforms-admin, the popped up window isn't dismissed properly because of a javascript error. This is due to the value being passed into the html_unescape() function - it is an integer but the function is expecting a string.

Attachments (2)

6100.diff​ (596 bytes ) - added by oggie_rob 18 years ago.
one-liner fix
6100.2.diff​ (979 bytes ) - added by Gary Wilson 18 years ago.

Download all attachments as: .zip

Change History (12)

by oggie_rob, 18 years ago

Attachment: 6100.diff​ added

one-liner fix

comment:1 by Simon G <dev@…>, 18 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin

comment:2 by anonymous, 18 years ago

Version: SVN → newforms-admin

comment:3 by Brian Rosner, 18 years ago

Marked #6104 as a duplicate.

comment:4 by Gary Wilson, 18 years ago

[6691] did not get merged correctly to newforms-admin.

by Gary Wilson, 18 years ago

Attachment: 6100.2.diff​ added

comment:5 by jkocherhans, 18 years ago

Any reason you haven't committed/closed this Gary?

comment:6 by Gary Wilson, 18 years ago

I don't have the permissions to commit to newforms-admin.

comment:7 by Brian Rosner, 18 years ago

Keywords: nfa-blocker added

I have also come across this problem. This needs to be included before the merge of newforms-admin.

comment:8 by David Grant, 18 years ago

Cc: davidgrant@… added

When I was using newforms-admin at the beginning of January I didn't see this bug but now I do for some reason.

comment:9 by Alex Gaynor, 18 years ago

Component: Uncategorized → Admin interface

comment:10 by Brian Rosner, 18 years ago

Resolution: → fixed
Status: new → closed

(In [7194]) newforms-admin: Fixed #6100 -- Related field popup window now closes properly after saving. Thanks oggie_rob and Gary Wilson.

Note: See TracTickets for help on using tickets.
Back to Top