Code

Opened 7 years ago

Closed 7 years ago

#6071 closed (fixed)

Revison 6777 / 6778: maximum recursion depth exceeded

Reported by: hans.rauch@… Owned by: trey
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Until revison 6777 my Django-program works fine. If I update to version 6778, I'll get the following error:

Request Method: GET
Request URL: http://dms.bildung.hessen.de/wir_ueber_uns/intern/index.html/edit/
Exception Type: RuntimeError
Exception Value: maximum recursion depth exceeded
Exception Location: /usr/local/lib64/python2.5/site-packages/django/utils/safestring.py in add, line 73
Python Executable: /usr/local/bin/python
Python Version: 2.5.1

The error occurs, if I try to show a form (newforms).

Attachments (5)

trace.txt (17.3 KB) - added by hans.rauch@… 7 years ago.
Traceback
utils.py (33.8 KB) - added by hans.rauch@… 7 years ago.
form_system.py (7.5 KB) - added by hans.rauch@… 7 years ago.
views_add.py (5.8 KB) - added by hans.rauch@… 7 years ago.
6813_SafeString_Updates.patch (2.7 KB) - added by trey 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Need to see your relevant source code, and a full traceback that includes line numbers within your source code.

Changed 7 years ago by hans.rauch@…

Traceback

Changed 7 years ago by hans.rauch@…

Changed 7 years ago by hans.rauch@…

Changed 7 years ago by hans.rauch@…

comment:2 Changed 7 years ago by Karen Tracey <kmtracey@…>

The traceback seems to have been truncated at 200 lines. Could you also attach one that shows just the traceback, not all the local vars (that is, post what you see after clicking "Switch to copy-and-paste view")? What's visible in the first one doesn't show how the code gets into deep recursion.

comment:3 Changed 7 years ago by trey

  • Has patch set
  • Owner changed from nobody to trey
  • Status changed from new to assigned

There were some additional SafeString issues earlier today. This patch includes updated tests and new SafeString operations that should be nicer when adding safe strings together as well as plain strings to safe strings.

Changed 7 years ago by trey

comment:4 Changed 7 years ago by Simon G <dev@…>

  • Triage Stage changed from Unreviewed to Accepted

comment:5 Changed 7 years ago by hans.rauch@…

  • Resolution set to fixed
  • Status changed from assigned to closed

Thanks! The patch 6813_SafeString_Updates.patch is working well.

By the way: I couldn't send you the 'Switch to copy-and-paste view', since it was empty.

comment:6 Changed 7 years ago by Simon G <dev@…>

  • Resolution fixed deleted
  • Status changed from closed to reopened

Glad to hear it works for you Hans, but we'll keep this opened until it's merged into Django's trunk (and is truly fixed).

comment:7 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6845]) Fixed #6071 -- Fixed another infinite recursion problem in SafeString and
SafeUnicode. Thanks, Trey Long.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.