Opened 9 years ago

Closed 3 years ago

#6066 closed New feature (wontfix)

Post-syncdb signal should include a list of done/to-be-done apps.

Reported by: Jacob Owned by: floguy
Component: Core (Management commands) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

See #2453 -- sometimes you need to run code/SQL at a particular point during initialization. I'd think two params: done and {{todo}}}, each of which contains a list of apps that have/have not yet been processed.

(Of course, other implementation ideas are welcome; that's just the first that comes to my mind.)

Attachments (2)

6066.diff (938 bytes) - added by floguy 9 years ago.
Added done and todo as kwargs to the post_syncdb signal
6066-2.diff (949 bytes) - added by floguy 9 years ago.
Updated patch to newest qs-rf revision 7260, and (potentially) fixed speed a bit. All tests pass.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 9 years ago by floguy

Needs tests: set

Added done and todo as kwargs to the post_syncdb signal.

todo is a set containing the apps which need to be signalled, including the current app.

done is a set containing the apps which have already been signalled, excluding the current app.

Changed 9 years ago by floguy

Attachment: 6066.diff added

Added done and todo as kwargs to the post_syncdb signal

comment:2 Changed 9 years ago by floguy

Owner: changed from nobody to floguy
Status: newassigned

comment:3 Changed 9 years ago by floguy

Has patch: set

Changed 9 years ago by floguy

Attachment: 6066-2.diff added

Updated patch to newest qs-rf revision 7260, and (potentially) fixed speed a bit. All tests pass.

comment:4 Changed 9 years ago by Malcolm Tredinnick

This doesn't have anything to do with qs-rf does it? I can't see any dependency there. So it should just be applied directly to trunk (although I suspect the existing patch will apply to trunk as well, since I've only made minimal changes in that file on the branch).

comment:5 Changed 9 years ago by floguy

Yeah, I just applied it to qs-rf since there were > 0 changes in sql.py in that branch. I just checked and it does in fact apply cleanly to trunk.

comment:6 Changed 6 years ago by Gabriel Hurley

Severity: Normal
Type: New feature

comment:7 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:8 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:9 Changed 4 years ago by Aymeric Augustin

Component: Core (Other)Core (Management commands)

comment:10 Changed 3 years ago by Aymeric Augustin

Resolution: wontfix
Status: assignedclosed

I don't think this feature request makes sense anymore after the migrations refactor.

If you want to reframe it in a way that's compatible with migrations, please open a new ticket referencing this one.

Note: See TracTickets for help on using tickets.
Back to Top