Opened 17 years ago
Closed 17 years ago
#6020 closed (wontfix)
Allow group comparing with basestring
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Contrib apps | Version: | dev |
Severity: | Keywords: | auth, group, improvement | |
Cc: | Triage Stage: | Design decision needed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Sometimes, i have to check is a user is in a particular group(from auth), and i have to load the group
i'm checking against, before i can use the "in" operator. Something like this:
MyGroupName="badass_people" group=Group.objects.get(name=MyGroupName) if group in user.groups: ... else: ...
I would like to suggest the overwrite of the method cmp, so that something like this:
group="badass_people" if group in user.groups: ... else: ...
I believe the code to do so is something like this:
class Group(models.Model): #stuff stuff ... def __cmp__(self, group): if isinstance(group, basestring): return cmp(self.name,group) #more stuff...
Change History (2)
comment:1 by , 17 years ago
Keywords: | improvement added; improviment removed |
---|---|
Summary: | Group comparing with basestring → Allow group comparing with basestring |
Triage Stage: | Unreviewed → Design decision needed |
comment:2 by , 17 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
I'm really not a fan of this. Though it looks nice for the
if 'group' in user.groups
case, I don't think that"group" == some_group_object
should be true. Strings and groups are very different beasts.