URLField does not allow URLs starting with ftp://

[Soeren Sonnenburg <bugreports@…>]

basically line 409 in newforms/fields.py is too restrictive

instead of

url_re = re.compile(
    r'^https?://' # http:// or https://
    r'(?:(?:[A-Z0-9-]+\.)+[A-Z]{2,6}|' #domain...
    r'localhost|' #localhost...
    r'\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})' # ...or ip
    r'(?::\d+)?' # optional port
    r'(?:/?|/\S+)$', re.IGNORECASE)

it should rather be

url_re = re.compile(
    r'^(ftp|https?)://' # http:// or https://
    r'(?:(?:[A-Z0-9-]+\.)+[A-Z]{2,6}|' #domain...
    r'localhost|' #localhost...
    r'\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})' # ...or ip
    r'(?::\d+)?' # optional port
    r'(?:/?|/\S+)$', re.IGNORECASE)

to allow normal ​ftp://foo.bar urls - this works with validation too...

[Alex Gaynor]

Makes sense, are there any other protocols we would want to support.

[Soeren Sonnenburg <bugreports@…>]

I could not think of anything else, e.g. ​mailto:// is handled in a separate field and cannot be checked the same way, ​file:// does not really make sense, gopher:// is not exactly popular...

[Soeren Sonnenburg <bugreports@…>]

on the other hand, one could be future proof(tm) and add a prefix argument that defaults to url_prefix='(ftp|https?)' which is then integrated in the re ...

[Jacob]

I've created #6092 to track the bigger issue here.

[anonymous]

please add rsync and nfs also

[Ramiro Morales]

Reverting anonymous reopen