Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#576 closed defect (fixed)

[patch] don't show 'add another' button in popup

Reported by: hp@… Owned by: adrian
Component: contrib.admin Version:
Severity: major Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This patch removes the 'add another' functionality from popups, as it breaks the javascript dynamic add stuff.

In some cases it can even lead to inconsistent data, if you "Add another" and after that add another one, the wrong data might be present in the browser, this only happened once to me, but still.

anyway, this is not the ideal, end to end solution, but it makes the interface consistent.

The 'ideal' solution would be to fix the javascript update thingy, but that is non-trivial, and would require some extensive work to the entire admin interface, there'd need to be some kind of javascript > python callback mechanism. I know how to implement such a thing, and I might actually do it :) who knows ;)

if someone else wants to do it, I'm happy to give help.

Attachments (1)

no_addanother_in_popup.diff (938 bytes) - added by hp@… 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by hp@…

comment:1 Changed 10 years ago by jacob

Can you be more specific about what is broken "stuff" and "inconsistent data"? The "nested" add another functions seem to work fine for me, and the usefulness is such that I'm inclined to keep the feature in unless the problems are severe.

comment:2 Changed 10 years ago by Hein-Pieter van Braam <hp@…>

The nested add another function works fine for the data you are updating, but, once you press 'save' and the window closes, after inserting a couple of new records/objects whatever they are called :) the JS updates only the *last* field that got saved. I got data inconsistency after selecting that field in HTML (the last one I added) in the end it showed up as one I put in earlier (some wrong ID perhaps?)

It only happened twice now, and I wasn't able to reproduce it accuratly, but it seems to happen if you add a lot of records before pressing save (I'd say 5+)

It's pretty random, and this is just a temoral workaround until I (or someone else) comes up with a proper callback mechanism.

comment:3 Changed 10 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [731]) Fixed #576 - popups no longer show "save & continue" buttons. Thanks, Hein-Pieter

Note: See TracTickets for help on using tickets.
Back to Top