Opened 11 years ago

Closed 8 years ago

#575 closed defect (fixed)

edit_inline don't save child data when a "blank=True" field is not set

Reported by: pylorca Owned by: nobody
Component: contrib.admin Version: master
Severity: major Keywords: nfa-fixed
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

when I try to insert or modify throught the admin interface, child data is not saved when there is a "blank=True" field and it's not set.

example:

model:

class Person(meta.Model):
    name = meta.CharField(maxlength=30)
    lastName = meta.CharField(maxlength=30)

class Phone:
    person = meta.ForeignKey(Person, edit_inline=meta.STACKED, num_in_admin=2)
    number = meta.CharField(maxlength=30, core=True)
    description = meta.CharField(maxlength=100, blank=True, core=True)

if I set a Phone number and I don't set description, this don't throw any error, but the Phone data is not saved, but this would be saved if I set the description too

Change History (9)

comment:1 Changed 9 years ago by Gary Wilson <gary.wilson@…>

Triage Stage: Ready for checkinAccepted

Maybe the blank=True in not playing nice with core=True. The edit_inline stuff will be changing in the newforms-admin branch.

Anyhow, this is not ready for checkin.

comment:2 Changed 9 years ago by clarice

Cc: ashleigh added
Component: Admin interfacedjango.newforms
Keywords: ashleigh added
Triage Stage: AcceptedReady for checkin
Version: 0.91

comment:3 Changed 9 years ago by alishia

Component: django.newformsDocumentation
Triage Stage: Ready for checkinAccepted
Version: 0.91other branch

comment:4 Changed 9 years ago by Gary Wilson

Cc: ashleigh removed
Component: DocumentationAdmin interface
Keywords: ashleigh removed
Version: other branchSVN

reverted spam

comment:5 in reply to:  4 Changed 9 years ago by anonymous

Component: Admin interfaceDatabase wrapper
Resolution: wontfix
Status: newclosed
Triage Stage: AcceptedDesign decision needed

Replying to gwilson:

reverted spam

comment:6 Changed 9 years ago by James Bennett

Component: Database wrapperAdmin interface
Triage Stage: Design decision neededAccepted

comment:7 Changed 9 years ago by Chris Beaven

Resolution: wontfix
Status: closedreopened

Reverting close by anonymous

comment:8 Changed 9 years ago by Brian Rosner

Keywords: nfa-fixed added

This is no longer a problem with newforms-admin. core=True usage is completely gone. Tagging with nfa-fixed to be closed when newforms-admin is merged.

comment:9 Changed 8 years ago by Brian Rosner

Resolution: fixed
Status: reopenedclosed

This is no longer a problem since the merge of newforms-admin in [7967].

Note: See TracTickets for help on using tickets.
Back to Top