Code

Opened 9 years ago

Closed 6 years ago

#575 closed defect (fixed)

edit_inline don't save child data when a "blank=True" field is not set

Reported by: pylorca Owned by: nobody
Component: contrib.admin Version: master
Severity: major Keywords: nfa-fixed
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

when I try to insert or modify throught the admin interface, child data is not saved when there is a "blank=True" field and it's not set.

example:

model:

class Person(meta.Model):
    name = meta.CharField(maxlength=30)
    lastName = meta.CharField(maxlength=30)

class Phone:
    person = meta.ForeignKey(Person, edit_inline=meta.STACKED, num_in_admin=2)
    number = meta.CharField(maxlength=30, core=True)
    description = meta.CharField(maxlength=100, blank=True, core=True)

if I set a Phone number and I don't set description, this don't throw any error, but the Phone data is not saved, but this would be saved if I set the description too

Attachments (0)

Change History (9)

comment:1 Changed 7 years ago by Gary Wilson <gary.wilson@…>

  • Triage Stage changed from Ready for checkin to Accepted

Maybe the blank=True in not playing nice with core=True. The edit_inline stuff will be changing in the newforms-admin branch.

Anyhow, this is not ready for checkin.

comment:2 Changed 7 years ago by clarice

  • Cc ashleigh added
  • Component changed from Admin interface to django.newforms
  • Keywords ashleigh added
  • Triage Stage changed from Accepted to Ready for checkin
  • Version set to 0.91

comment:3 Changed 7 years ago by alishia

  • Component changed from django.newforms to Documentation
  • Triage Stage changed from Ready for checkin to Accepted
  • Version changed from 0.91 to other branch

comment:4 follow-up: Changed 7 years ago by gwilson

  • Cc ashleigh removed
  • Component changed from Documentation to Admin interface
  • Keywords ashleigh removed
  • Version changed from other branch to SVN

reverted spam

comment:5 in reply to: ↑ 4 Changed 7 years ago by anonymous

  • Component changed from Admin interface to Database wrapper
  • Resolution set to wontfix
  • Status changed from new to closed
  • Triage Stage changed from Accepted to Design decision needed

Replying to gwilson:

reverted spam

comment:6 Changed 7 years ago by ubernostrum

  • Component changed from Database wrapper to Admin interface
  • Triage Stage changed from Design decision needed to Accepted

comment:7 Changed 6 years ago by SmileyChris

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Reverting close by anonymous

comment:8 Changed 6 years ago by brosner

  • Keywords nfa-fixed added

This is no longer a problem with newforms-admin. core=True usage is completely gone. Tagging with nfa-fixed to be closed when newforms-admin is merged.

comment:9 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from reopened to closed

This is no longer a problem since the merge of newforms-admin in [7967].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.