[newforms-admin] inline_formset() doesn't allow customized forms

[Antti Kaihola]

As described in ​the documentation, the form_for_model() and form_for_instance() functions accept a form= keyword argument for specifying a custom form as their base classes.

In the newforms-admin branch, the formset_for_model() function supports a similar form= keyword argument, but the inline_formset() function does not. It would be useful to have this functionality.

[Antti Kaihola]

simple patch to provide this functionality

[Antti Kaihola]

Actually it would be useful to have the formset= keyword argument as well, i.e. to be able to view only a subset of the related objects.

[Antti Kaihola]

added the formset= kwarg, changed kwarg order

[Antti Kaihola]

In the second patch I added the formset= kwarg and reordered keyword arguments in both inline_formset() and formset_for_model() to match those of functions further down the call stack. Might reduce confusion if someone wants to omit keywords and provide values as positional arguments.

[Brian Rosner]

This is generally a good idea, however, inline formsets will be changing before newforms-admin is considered complete. Will mark as DDN to see if this will be needed after some refactoring.

[Brian Rosner]

Ok, now since formset_for_queryset is in newforms-admin (r6655) this is now a very good idea.

[Brian Rosner]

I firmly believe this needs to be included before a merge to trunk. It is actually blocking my ability to write a good patch for #5721. Tagging with nfa-blocker.

[mrts]

This has been fixed with the new form class field in admin classes. Tested with StackedInline, works correctly.