Opened 9 years ago

Closed 9 years ago

#5721 closed (fixed)

Objects with file fields, edited inline, throws validation errors on edit

Reported by: reidab@… Owned by: brosner
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: sjulean@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


This is similar to #26.

I have an object with multiple related file attachments, each represented by a related object that i'm editing inline (tabular).

When I edit the parent object, it displays the current value of the file field as a link above the file input.
If I save the parent object, the empty file fields (labeled Change:) throw "This field is required" errors, even though the field has a current value.

It seems that validation on file fields should check both for input (and replace if it exists) and for an existing value.

Change History (7)

comment:1 Changed 9 years ago by brosner

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 9 years ago by brosner

  • Owner changed from nobody to brosner
  • Status changed from new to assigned

comment:3 Changed 9 years ago by brosner

Almost forgot to reference some discussion on django-dev:

comment:4 Changed 9 years ago by sjulean

  • Cc sjulean@… added

comment:5 Changed 9 years ago by brosner

  • Keywords nfa-blocker added; fileuploadfield filefield admin newforms-admin removed

This is something that is broken in newforms-admin and doesn't match current trunk's admin behavior. I will have a patch for this soon.

comment:6 Changed 9 years ago by brosner

#6241 really supersedes this ticket since the attached patch there fixes this problem. Won't close this ticket quite yet.

comment:7 Changed 9 years ago by brosner

  • Resolution set to fixed
  • Status changed from assigned to closed

This was fixed in r7021 and merged over in r7022.

Note: See TracTickets for help on using tickets.
Back to Top