Code

Opened 7 years ago

Closed 7 years ago

#5720 closed (fixed)

[newforms-admin] - remove legacy Manipulator code

Reported by: brosner Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

I ran across a problem with having about 10,000 rows in a foreign key table and was using newforms-admin. I tracked it down to some legacy code that wanted to do something dumb and the reason for newforms in the first place. Per the discussion at http://groups.google.com/group/django-users/browse_frm/thread/a0a00061c0331107, I am creating this ticket and posting a patch to move render_change_form out of django.contrib.admin.views.main and into the ModelAdmin class. This also get rid of the dependancy of the ChangeManipulator and AddManipulator in newforms-admin.

Attachments (1)

5720_newforms_admin_legacy_code_removal.diff (5.4 KB) - added by brosner 7 years ago.

Download all attachments as: .zip

Change History (2)

Changed 7 years ago by brosner

comment:1 Changed 7 years ago by jkocherhans

  • Resolution set to fixed
  • Status changed from new to closed

(In [6470]) newforms-admin: Fixed #5720. render_change_form now belongs to ModelAdmin and no longer uses manipulators. Thanks Brian Rosner.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.