Opened 8 years ago

Closed 8 years ago

#5706 closed (fixed)

Two HTML errors in Admin documentation.

Reported by: Rob van der Linde <robvdl@…> Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

With my projects, I like to use DEFAULT_CONTENT_TYPE = 'application/xhtml+xml' in my settings.py file. I then use an XhtmlDegrader? middleware, to gracefully degrade my pages to text/html to browsers that do not support this mimetype, such as IE.

I found another two bugs, this time, if you are in admin and click on documentation and are running in application/xhtml+xml mode, the bug does not happen in text/html mode, so maybe this is a good test to see if the HTML pages conform.

If I click on "Tags" documentation, I get:

XML Parsing Error: mismatched tag. Expected: </hr>.
Location: http://ynui.co.nz:8001/admin/doc/tags/
Line Number 631, Column 3:</div>
--^

IF I click on "Views" documentation, I get:

XML Parsing Error: mismatched tag. Expected: </h3>.
Location: http://ynui.co.nz:8001/admin/doc/views/
Line Number 73, Column 46:<h3><a href="foo.bar.views.index/"/>/</a></h3>
-----------------------------------------------^

All the other links under the documentation are fine.

Attachments (1)

5706.diff (1.7 KB) - added by tvrg 8 years ago.
patch for admin doc

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by tvrg

patch for admin doc

comment:1 Changed 8 years ago by tvrg

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 8 years ago by anonymous

  • Triage Stage changed from Accepted to Ready for checkin

comment:3 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6735]) Fixed #5706 -- Fixed a couple of XHTML incompatibilities. Based on a patch from
tvrg.

Note: See TracTickets for help on using tickets.
Back to Top