Code

Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#5705 closed (wontfix)

Admin login window CSS bug when using application/xhtml+xml

Reported by: Rob van der Linde <robvdl@…> Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

With my projects, I like to use DEFAULT_CONTENT_TYPE = 'application/xhtml+xml' in my settings.py file. I then use an XhtmlDegrader? middleware, to gracefully degrade my pages to text/html to browsers that do not support this mimetype, such as IE.

Everything else seems to be fine when using application/xhtml+xml for Admin, except one little minor bug with the login window.

The bug is that the background is not all covered in grey, but rather only a tiny strip. This bug does not occur when admin is served as text/html.

Usually this sort of bug happens if you put the background colour in the body{} selector, when it should be in html{} selector instead, as body{} only grows with the page content when in strict HTML mode, and may not necessarily cover the whole page.

To fix, move the grey background into the html{} selector in the CSS.

Attachments (0)

Change History (3)

comment:1 Changed 6 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by jacob

  • Resolution set to wontfix
  • Status changed from new to closed

The admin is HTML, not XHTML; that's just the color we chose to paint this particular bikeshed. Either don't serve the admin as XHTML, or else deal with the consequences.

comment:3 Changed 5 years ago by jacob

(And yes I'm aware that the admin uses an XHTML doctype. Pay no mind. That could be changed at some point, but there's precious little point pragmatically.)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.