Code

Opened 7 years ago

Closed 6 years ago

#5595 closed (fixed)

ModPythonRequest __repr__ is attempting to return a unicode object

Reported by: gwilson Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

And this is causing the repr of a ModPythonRequest object to have backslashes escaped, which is causing newlines not to be interpreted (noticed in my server errors coming to me via email).

Attachments (1)

5595.diff (2.7 KB) - added by gwilson 7 years ago.
made use of smart_str in ModPythonRequest repr

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by gwilson

made use of smart_str in ModPythonRequest repr

comment:1 Changed 7 years ago by gwilson

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I do need the unicode() calls for python2.3 compatibility, right?

comment:2 Changed 6 years ago by jacob

  • Triage Stage changed from Unreviewed to Ready for checkin

Gary, if these tests pass feel free to check this in; looks fine to me. IIRC you're right about needing the unicode() calls but it doesn't hurt if they're extraneous.

comment:3 Changed 6 years ago by gwilson

  • Resolution set to fixed
  • Status changed from new to closed

(In [7200]) Fixed #5595 -- Made ModPythonRequest.__repr__ return a string instead of a unicode object. Fixes the printout of the request object in those server error e-mails I never get :)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.