Opened 8 years ago

Closed 8 years ago

#5546 closed (fixed)

Split newforms tests

Reported by: leosoto <leo.soto@…> Owned by: nobody
Component: Forms Version: master
Severity: Keywords: jython
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


tests/regressiontests/forms/{,} are too big for Jython, where exists a limit of 32KB for the length of string literals.

And, IMO, they are too big for humans too.

Change History (2)

comment:1 Changed 8 years ago by leosoto <leo.soto@…>

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

[The patch size is more than 256KBytes, so trac don't let me attach it here.] splits localflavors tests into its own directory (one file per flavor) and form tests into four files: widgets, fields, forms and extras.

As and strings were still above 32KBytes, and I didn't knew a good criteria to split them more, string concatenation was used to avoid problems with Jython.

comment:2 Changed 8 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [6379]) Fixed #5546: split form unit tests into manageable chunks. This isn't a perfect fix since the chunks aren't yet autodiscovered, but that shouldn't prevent checking this in. Thanks, Leo Soto.

Note: See TracTickets for help on using tickets.
Back to Top