Opened 17 years ago
Closed 17 years ago
#5546 closed (fixed)
Split newforms tests
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | jython | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
tests/regressiontests/forms/{tests.py,localflavor.py
} are too big for Jython, where exists a limit of 32KB for the length of string literals.
And, IMO, they are too big for humans too.
Change History (2)
comment:1 by , 17 years ago
Has patch: | set |
---|
comment:2 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
[The patch size is more than 256KBytes, so trac don't let me attach it here.]
http://www.leosoto.com/split_newforms_tests2.patch splits localflavors tests into its own directory (one file per flavor) and form tests into four files: widgets, fields, forms and extras.
As widgets.py and forms.py strings were still above 32KBytes, and I didn't knew a good criteria to split them more, string concatenation was used to avoid problems with Jython.