Opened 8 years ago

Closed 8 years ago

#5438 closed (fixed)

GeometryProxy: evaluate empty string to None

Reported by: rcoup Owned by: jbronn
Component: GIS Version: gis
Severity: Keywords: sprint
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The following code:

from django.contrib.gis.test.geoapp.models import City
c = City()
c.point

throws an exception from GeometryProxy.__get__, because the geom_value is '', and so it tries to create a GEOSGeometry from it.

Attached patch and tests evaluates '' (and u'') to None instead.

Attachments (1)

proxy_newmodel_none.patch (1.6 KB) - added by rcoup 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by rcoup

comment:1 Changed 8 years ago by adrian

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Version changed from SVN to gis

comment:2 Changed 8 years ago by jbronn

  • Owner changed from nobody to jbronn
  • Status changed from new to assigned

comment:3 Changed 8 years ago by jbronn

  • Status changed from assigned to new

comment:4 Changed 8 years ago by jbronn

  • Resolution set to fixed
  • Status changed from new to closed

(In [6243]) gis: Fixed #5438 with patches from rcoup.

Note: See TracTickets for help on using tickets.
Back to Top