Opened 19 years ago
Closed 19 years ago
#542 closed enhancement (wontfix)
[patch] Add an "or cancel" link to add, edit, and delete admin views.
Reported by: | Jason Huggins | Owned by: | Wilson Miner |
---|---|---|---|
Component: | contrib.admin | Version: | |
Severity: | trivial | Keywords: | cancel link |
Cc: | Triage Stage: | Design decision needed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | UI/UX: |
Description
When creating, editing, or deleting an object in the admin views, it would be nice if there was a "cancel" link to allow the user to "go back safely".
Only 4 total lines of code are affected by this change.
Attachments (3)
Change History (12)
by , 19 years ago
Attachment: | or_cancel_patch.txt added |
---|
comment:1 by , 19 years ago
Status: | new → assigned |
---|
by , 19 years ago
Attachment: | Firefox001.png added |
---|
comment:2 by , 19 years ago
Jason, not to be picky but although I like the idea I think it looks kinda ugly -- see the screenshot. Think you could spend some time on spit and polish?
comment:4 by , 19 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
comment:5 by , 19 years ago
I seem to remember we debated this early on and decided it was unnecessary and potentially confusing, since you can effectively cancel by navigating away from the unsaved form at any time, which is pretty standard for web apps/forms.
I'm willing to reconsider provided a reasonably compelling usability argument or use case for why this method makes more sense.
comment:6 by , 19 years ago
Whoops. I thought I *did* add the spit and polish already... To be honest, I was using tadalist.com as inspiration for the "or cancel" link. So, I blame them for the lack of style. :-)
Regarding usability... perhaps the "or cancel" link at a minimum should be on the delete form... It's not obvious what you should in the delete confirmation page if you *don't* want to actually delete the object afterall. From a usability point of view... a simple "Yes or No" choice is expected... It's weird to see only a "Yes" option button... but no obvious way to cancel the action.
As an alternative to "or cancel"... I've also seen links in some web apps saying something like "Return to home"... which functionaly works the same as a cancel button. Basically, my point is... not all casual web app users know to or like to use breadcrumbs for all site navigation... Sometimes a little extra navigational help is a good thing.
comment:7 by , 19 years ago
I agree that the "Or cancel" should only go on the delete page. Having it on the add/change pages would get too cluttered and confusing.
by , 19 years ago
Attachment: | delete_confirmation.html added |
---|
Adds cancel button to right of "Yes, I'm Sure" button. Also adds CSS class to button.
comment:8 by , 19 years ago
I needed this myself.
Ignore my attached file. I should have put patches instead:
Index: contrib/admin/templates/admin/delete_confirmation.html =================================================================== --- contrib/admin/templates/admin/delete_confirmation.html (revision 1436) +++ contrib/admin/templates/admin/delete_confirmation.html (working copy) @@ -15,8 +15,9 @@ <ul>{{ deleted_objects|unordered_list }}</ul> <form action="" method="post"> <input type="hidden" name="post" value="yes" /> - <input type="submit" value="{% trans "Yes, I'm sure" %}" /> + <input type="submit" id="deleteconfirm" value="{% trans "Yes, I'm sure" %}" /> </form> + <input type="submit" id="deletecancel" value="{% trans "Cancel" %}" onclick="{window.location='..'}"/> {% endif %} {% endblock %} Index: contrib/admin/media/css/global.css =================================================================== --- contrib/admin/media/css/global.css (revision 1436) +++ contrib/admin/media/css/global.css (working copy) @@ -200,6 +200,8 @@ .deletelink { padding-left:12px; background:url(../img/admin/icon_deletelink.gif) 0 50% no-repeat; } a.deletelink:link, a.deletelink:visited { color:#CC3434; } a.deletelink:hover { color:#993333; } +#deleteconfirm { border-color:Red } +#deletecancel { position:relative; top:-27px; left:150px } /* OBJECT TOOLS */ .object-tools { font-size:10px; font-weight:bold; font-family:Arial,Helvetica,sans-serif; padding-left:0; margin-bottom:5px; float:right; position:relative; margin-top:- 2.4em; margin-bottom:-2em; }
comment:9 by , 19 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
I'm still unhappy with the way this looks; marking wontfix.
patch file