Opened 9 years ago

Closed 9 years ago

#5383 closed (fixed)

[newforms-admin] - InlineModelAdmin.formset_class is used but not set.

Reported by: Petr Marhoun <petr.marhoun@…> Owned by: jkocherhans
Component: contrib.admin Version: newforms-admin
Severity: Keywords: newforms, admin, inlines
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I think there is a little bug in [6080].

In InlineModelAdmin._fieldsets (row 684) attribute formset_class is used. But it was removed from init in [6080].

Attached patch gives it back.

I am not sure if it is the right solution - maybe only fields should be saved. See also #5372 - I think that it isn't a good idea to use one formset_class for all requests.

Attachments (1)

formset-class-not-set.diff (958 bytes) - added by Petr Marhoun <petr.marhoun@…> 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by Petr Marhoun <petr.marhoun@…>

Attachment: formset-class-not-set.diff added

comment:1 Changed 9 years ago by jkocherhans

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to jkocherhans
Patch needs improvement: unset
Status: newassigned
Triage Stage: UnreviewedAccepted

comment:2 Changed 9 years ago by jkocherhans

Resolution: fixed
Status: assignedclosed

(In [6102]) newforms-admin: Fixed #5383.

Note: See TracTickets for help on using tickets.
Back to Top