Cache inline ForeignKey options

[anonymous]

See ​http://groups.google.com/group/django-developers/msg/28a8d0efadc1b079

[Petr Marhoun <petr.marhoun@…>]

I have these models:

from django.db import models

class Category(models.Model):
    name = models.CharField(max_length=255)

class Library(models.Model):
    name = models.CharField(max_length=255)
    
class Book(models.Model):
    name = models.CharField(max_length=255)
    category = models.ForeignKey(Category)
    library = models.ForeignKey(Library)
    

And I register them:

class BookInline(admin.TabularInline):
    model = Book
    extra = 10
    fields = 'name', 'category',

class LibraryOptions(admin.ModelAdmin):
    inlines = BookInline,

admin.site.register(Library, LibraryOptions)

I have ten rows for books in library add form. Each row needs its own sql query to get list of categories. I think that the query should be cached.

It is caching in one request, not between requests. New forms and new formsets are created in each request.

[Petr Marhoun <petr.marhoun@…>]

New patch added - the old one doesn't work after [6080].

[Nicola Larosa]

The discussion about this one did not reach a consensus:

​http://groups.google.com/group/django-developers/browse_thread/thread/7aaa8a5297e3c4d5

therefore I'm taking its triage stage back.

[Brian Rosner]

This ticket isn't critical to merge of newforms-admin. Tagging with nfa-someday. This functionality can be accomplished by the user, but I personally feel it needs to be in Django.

[Brian Rosner]

fixes the real problem. formsets are declarative like forms. 85% done, but attaching to get feedback.

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Collin Anderson]

actually, a prefetch_related() call might work just as well.

[Martín Blech]

I did some work on this branch: ​https://github.com/martinblech/django/tree/ticket_5372
Does it make sense?

[Simon Charette]

I turned your branch into ​a PR for easier reviewing and testing.

[Simon Charette]

As pointed out on Github the prefetch_related() approach won't work until inline formsets are taught how to deal with it (#18597).