Opened 8 years ago

Closed 8 years ago

#5357 closed (fixed)

Documentation should include page argument of object_list

Reported by: Brian Morton <rokclimb15@…> Owned by: mitja
Component: Documentation Version: master
Severity: Keywords: object_list, page, pagination, sprintsept14
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently, the generic view documentation at http://www.djangoproject.com/documentation/generic_views/#django-views-generic-list-detail-object-list makes no mention of the page keyword argument, which is the current page being viewed. This is transparent if you are calling object_list from the urlconf, since the view receives this argument on its own. However, if you are writing a wrapper around object_list, it is important to know that it accepts the page argument since you must intercept it and pass it yourself. Otherwise the view will not function properly with pagination.

Attachments (1)

generic_views_r6243.diff (832 bytes) - added by mitja 8 years ago.
Adds documentation for page argument against r6243

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Simon G. <dev@…>

  • Needs documentation set
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 8 years ago by flother

  • Resolution set to duplicate
  • Status changed from new to closed

Marked as duplicate as this was patched in #4330 and fixed in [5293].

comment:3 Changed 8 years ago by flother

  • Resolution duplicate deleted
  • Status changed from closed to reopened

Oops, that last comment was meant for #3757. Reopened.

comment:4 Changed 8 years ago by nickefford

  • Owner changed from nobody to nickefford
  • Status changed from reopened to new

comment:5 Changed 8 years ago by mitja

  • Owner changed from nickefford to mitja
  • Status changed from new to assigned

Changed 8 years ago by mitja

Adds documentation for page argument against r6243

comment:6 Changed 8 years ago by mitja

  • Has patch set
  • Keywords sprintsept14 added

comment:7 Changed 8 years ago by ubernostrum

  • Triage Stage changed from Accepted to Ready for checkin

Patch looks good to me.

comment:8 Changed 8 years ago by russellm

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6280]) Fixed #5357 -- Added documentation on the 'page' argument to generic object_list views. Thanks, mitja.

Note: See TracTickets for help on using tickets.
Back to Top