Formsets - formset.required_forms not implemented?

[Simon Litchfield <simon@…>]

Setting formset.required_forms seems to make no difference to formset validation.

I guess we need something similar to ErrorDict to handle formset errors?

Since form errors will most likely be accessed directly, I tend to think the default formset.errors should be reserved for formset errors instead of individual formset errors, or at least a combination of the two.

Then formset.form_errors could be used to return the list of individual forms' errors.

[Simon Litchfield <simon@…>]

Adds formset.formset_errors ErrorList if number of required_forms is not met

[Simon Litchfield <simon@…>]

(ignore previous) Adds formset.formset_errors ErrorList if number of required_forms is not met

[Simon Litchfield <simon@…>]

(ignore previous!!!) Adds formset.formset_errors ErrorList if number of required_forms is not met

[Simon Litchfield <simon@…>]

USE THIS ONE

[Simon Litchfield <simon@…>]

USE THIS ONE

[Simon Litchfield <simon@…>]

Excuse the mess, the diff previewer doesn't seem to like my diffs for some reason.

This patch covers 5173, 5174, 5175 (again, excuse, one snag encountered after another).

A couple of other nasty little bugs fixed too.

[jkocherhans]

formset.required_forms is not meant to be a public attribute. Setting it would have unpredictable results. That said, FormSets still need a hook to do validation on *all* forms in the set. I imagine that's what you want here. I've opened up #5353 to track that. Something like ErrorDict would probably be useful, but that discussion needs to occur on django-dev. Not enough people will see it here. If you have a design in mind, please propose it there. Otherwise, I'll keep it in mind when I get around to implementing #5353.