Opened 7 years ago

Closed 7 years ago

#5353 closed (fixed)

FormSet validation hook(s)

Reported by: jkocherhans Owned by: Honza_Kral
Component: Forms Version: newforms-admin
Severity: Keywords: sprintsept14
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

We need a hook similar to the clean hook on newforms to do validation on all forms in a FormSet. This would allow min/max checks on the number of forms submitted and also allow a place to put unique_together style validation for inlines.

Attachments (2)

5353-BaseFormSet.clean.patch (2.7 KB) - added by Honza_Kral 7 years ago.
take one
5353-BaseFormSet.clean_with_simple_tests.patch (9.9 KB) - added by Honza_Kral 7 years ago.
added some tests and synced with 6245

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by jkocherhans

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 7 years ago by Honza_Kral

  • Owner changed from nobody to Honza_Kral
  • Status changed from assigned to new

Changed 7 years ago by Honza_Kral

take one

Changed 7 years ago by Honza_Kral

added some tests and synced with 6245

comment:3 Changed 7 years ago by Honza_Kral

  • Keywords sprintsept14 added

comment:4 Changed 7 years ago by Honza_Kral

  • Has patch set

added has patch

comment:5 Changed 7 years ago by jkocherhans

  • Resolution set to fixed
  • Status changed from new to closed

(In [6419]) newforms-admin: Fixed #5353. Added FormSet validation hook. Separated a few things out from the original patch and added more tests. Thanks, Honza Kral.

Note: See TracTickets for help on using tickets.
Back to Top