Opened 17 years ago

Closed 12 years ago

#5116 closed New feature (duplicate)

newforms: SelectMultiple widget: disable some entries

Reported by: Thomas Güttler <hv@…> Owned by: Philippe Raoult
Component: Forms Version: dev
Severity: Normal Keywords: feature
Cc: hv@…, bmispelon@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Hi,

here is a small patch to disable some items in a
SelectMultiple widget.

Attachments (3)

newforms_widgets_selectm_disable.diff​ (1.6 KB ) - added by Thomas Güttler <hv@…> 17 years ago.
newforms_select_disable.diff​ (5.3 KB ) - added by Thomas Güttler <hv@…> 17 years ago.
newforms_select_disable-2.diff​ (5.3 KB ) - added by Thomas Güttler <hv@…> 17 years ago.

Download all attachments as: .zip

Change History (16)

by Thomas Güttler <hv@…>, 17 years ago

Attachment: newforms_widgets_selectm_disable.diff​ added

comment:1 by Philippe Raoult, 17 years ago

Keywords: feature added
Needs documentation: set
Owner: changed from nobody to Philippe Raoult
Triage Stage: Unreviewed → Design decision needed

comment:2 by Thomas Güttler <hv@…>, 17 years ago

Cc: hv@… added

by Thomas Güttler <hv@…>, 17 years ago

Attachment: newforms_select_disable.diff​ added

comment:3 by Thomas Güttler <hv@…>, 17 years ago

Has patch: unset
Needs documentation: unset

I attached a new patch. It includes documentation an tests.

comment:4 by Thomas Güttler <hv@…>, 17 years ago

Has patch: set

by Thomas Güttler <hv@…>, 17 years ago

Attachment: newforms_select_disable-2.diff​ added

comment:5 by Thomas Güttler <hv@…>, 17 years ago

newforms_select_disable-2.diff is an update to apply cleanly to the current trunk.

comment:6 by Philippe Raoult, 17 years ago

Triage Stage: Design decision needed → Ready for checkin

tests are working, documentation is up to date.

comment:7 by Malcolm Tredinnick, 17 years ago

Triage Stage: Ready for checkin → Design decision needed

Best practice is to leave out entries that cannot be selected, not disable them. So it's not clear that this is a good change to make.

comment:8 by Philippe Raoult, 17 years ago

Patch needs improvement: set

We could accept a patch that makes it easier to subclass Select though. Then you can post your disable option as a snippet subclassing Select.

comment:9 by Russell Keith-Magee, 14 years ago

Triage Stage: Design decision needed → Accepted

This is an option in the HTML spec, so we should be able to expose it in some way.

comment:10 by Gabriel Hurley, 14 years ago

Severity: → Normal
Type: → New feature

comment:11 by Aymeric Augustin, 13 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:12 by Aymeric Augustin, 13 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:13 by Baptiste Mispelon, 12 years ago

Cc: bmispelon@… added
Resolution: → duplicate
Status: new → closed

This is a duplicate of #16149 which also has a patch but is a bit more generic.

Note: See TracTickets for help on using tickets.
Back to Top