#5102 closed (fixed)
Allow zero pk inserts in post_syncdb
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Core (Other) | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In setting up a database, it is nice to allow for pk=0 objects in the database (specifically to deal with non-null foreign keys). Because of indexes, this is possible only when post_syncdb is triggered (and not via fixtures), but since it is a logical data entry it makes sense to allow code entries for it. For example:
User.objects.create(id=0, username='', first_name='', last_name='', email='', password='', is_active=False, is_staff=False, is_superuser=False, date_joined=datetime(1900,1,1), last_login=datetime(1900,1,1))
However one line prevents this by using bool(pk_val), which is the same for pk_val is None and pk_val = 0. The patch fixes this and allows for post_syncdb additions of zero pk inserts.
Attachments (1)
Change History (4)
by , 17 years ago
Attachment: | zero_pk.diff added |
---|
comment:1 by , 17 years ago
Summary: | [patch] Allow zero pk inserts in post_syncdb → Allow zero pk inserts in post_syncdb |
---|---|
Triage Stage: | Unreviewed → Ready for checkin |
comment:2 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
One-liner diff to use "is not None" instead of "bool"