Opened 9 years ago

Closed 9 years ago

#5045 closed (duplicate)

Primary keys containing URL characters breaks admin links

Reported by: robbie@… Owned by: Adrian Holovaty
Component: contrib.admin Version: master
Severity: Keywords: unicode
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The quote function, used by the admin application to escape url characters, incorrectly checks for strings:

    if type(s) != type(''):
        return s

This obviously fails now that Django can return a unicode string for field values, resulting in broken links for objects with url characters in their primary key.

Checking against basestring would seem to be one way to go:

    if not isinstance(s, basestring):
        return s

...but perhaps the admin application should be changed to use django.utils.http.urlquote since this performs a similar function?

Attachments (1)

admin-quote_unicode.patch (506 bytes) - added by robbie@… 9 years ago.
Simple patch to correctly catch strings & unicode strings

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by robbie@…

Attachment: admin-quote_unicode.patch added

Simple patch to correctly catch strings & unicode strings

comment:1 Changed 9 years ago by jdetaeye@…

Ticket #5041 also touches on this problem.

comment:2 Changed 9 years ago by Chris Beaven

Resolution: duplicate
Status: newclosed

Closing as a duplicate of #5041, since that incorporates this change and has been accepted.

Note: See TracTickets for help on using tickets.
Back to Top