Opened 17 years ago
Closed 17 years ago
#5044 closed (fixed)
Update urlify.js with missing characters
| Reported by: | dall | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | sprintsept14 | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
my (latvian) language, characters like - āšžčļņī, needs to be converted to aszclni, not to disaper.
Attachments (1)
Change History (13)
comment:1 by , 17 years ago
| Component: | Uncategorized → Admin interface |
|---|---|
| Owner: | changed from to |
comment:2 by , 17 years ago
comment:3 by , 17 years ago
This ticket requires someone familiar with the Latvian alphabet to write a patch similar to those on ticket #4365 for source:django/trunk/django/contrib/admin/media/js/urlify.js.
follow-up: 5 comment:4 by , 17 years ago
| Keywords: | sprintsept14 added |
|---|---|
| Triage Stage: | Unreviewed → Design decision needed |
Good question.. How do we handle foreign-language slugs in Django?
follow-up: 7 comment:5 by , 17 years ago
Replying to webjunkie:
Good question.. How do we handle foreign-language slugs in Django?
Look at the JavaScript file linked in the comment above yours.
comment:6 by , 17 years ago
The slugify filter would also need to be updated, since the JS isn't the only method for populating slugs
follow-up: 8 comment:7 by , 17 years ago
Replying to ubernostrum:
Replying to webjunkie:
Good question.. How do we handle foreign-language slugs in Django?
Look at the JavaScript file linked in the comment above yours.
It was more of a rhetorical question if we really handle them correct in every case. For example, German is not handled right.
comment:8 by , 17 years ago
Replying to webjunkie:
It was more of a rhetorical question if we really handle them correct in every case. For example, German is not handled right.
With test cases (at least for the slugify part) to make sure conversions are OK I guess.
comment:9 by , 17 years ago
| Summary: | utf-8 characters in SlugField (prepopulate_from) → Update urlify.js with missing characters |
|---|---|
| Triage Stage: | Design decision needed → Accepted |
As Dimitris said, someone needs to update urlify.js with the appropriate characters. I'm changing the title to reflect that.
comment:10 by , 17 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
The patch adds characters from the Latvian alphabet. This should be good to go.
(There is a larger issue here, though: slugifying nicely is dependent on language. For example, 'ü' in German should be converted to 'ue', but in Dutch, French or Spanish it should be converted to 'u', as it is now. See #2176 for a request to change the way characters with umlauts are handled from a German perspective.)
comment:12 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Currently (latest SVN copy) āšžčļņī is converted to "szc".