Opened 17 years ago
Closed 17 years ago
#4964 closed (fixed)
Brazilian local flavor new BRStateChoiceField
| Reported by: | Wiliam Alves de Souza | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.localflavor | Version: | dev |
| Severity: | Keywords: | localflavor | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
"A choice field that uses a list of Brazilian states as its choices."
Attachments (2)
Change History (7)
by , 17 years ago
| Attachment: | brlocalflavor.diff added |
|---|
comment:1 by , 17 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
comment:2 by , 17 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
by , 17 years ago
| Attachment: | brlocalflavorv2.diff added |
|---|
Changes based on Malcolm Tredinnick comments.
comment:3 by , 17 years ago
| Patch needs improvement: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
comment:4 by , 17 years ago
| Summary: | Brazilian local flavor new BRStateChoiceField and code refactoring → Brazilian local flavor new BRStateChoiceField |
|---|
William - please feel free to open a new ticket with the proposed code refactoring.
comment:5 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
This isn't ready for checkin.
Please write a patch that only adds the new feature you are wanting. As a general rule, and particularly here, one change per ticket is the right approach.
As far as I can work out, the refactoring changes aren't really making anything clearer or better. They are just making it different. So I'd like to remove them from the patch and let's just look at the new feature.