Opened 9 years ago

Closed 9 years ago

#4964 closed (fixed)

Brazilian local flavor new BRStateChoiceField

Reported by: Wiliam Alves de Souza Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Keywords: localflavor
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

"A choice field that uses a list of Brazilian states as its choices."

Attachments (2)

brlocalflavor.diff (11.4 KB) - added by wiliamsouza83@… 9 years ago.
brlocalflavorv2.diff (3.7 KB) - added by Wiliam Alves de Souza 9 years ago.
Changes based on Malcolm Tredinnick comments.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by wiliamsouza83@…

Attachment: brlocalflavor.diff added

comment:1 Changed 9 years ago by Simon G. <dev@…>

Triage Stage: UnreviewedReady for checkin

comment:2 Changed 9 years ago by Malcolm Tredinnick

Patch needs improvement: set
Triage Stage: Ready for checkinAccepted

This isn't ready for checkin.

Please write a patch that only adds the new feature you are wanting. As a general rule, and particularly here, one change per ticket is the right approach.

As far as I can work out, the refactoring changes aren't really making anything clearer or better. They are just making it different. So I'd like to remove them from the patch and let's just look at the new feature.

Changed 9 years ago by Wiliam Alves de Souza

Attachment: brlocalflavorv2.diff added

Changes based on Malcolm Tredinnick comments.

comment:3 Changed 9 years ago by Simon G. <dev@…>

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:4 Changed 9 years ago by Simon G. <dev@…>

Summary: Brazilian local flavor new BRStateChoiceField and code refactoringBrazilian local flavor new BRStateChoiceField

William - please feel free to open a new ticket with the proposed code refactoring.

comment:5 Changed 9 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [6176]) Fixed #4964 -- Added Brazilian state field to localflavors. Thanks, William Alves de Souza.

Note: See TracTickets for help on using tickets.
Back to Top