Opened 18 years ago

Closed 17 years ago

#4951 closed (fixed)

sites.RequestSite incorrectly reports domain

Reported by: Caleb Owned by: nobody
Component: Contrib apps Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

If you run the development server then sites.RequestSite does not include the port number in the domain. This patch seems to fix the problem.

Change History (5)

by Caleb <jtxx000@…>, 18 years ago

Attachment: models.diff​ added

comment:1 by Chris Beaven, 18 years ago

Component: Uncategorized → Contrib apps
Owner: changed from Jacob to Adrian Holovaty
Triage Stage: Unreviewed → Design decision needed

I did wonder at why it was using SERVER_NAME over the get_host method. Not sure if it is by choice or not.

comment:2 by Chris Beaven, 18 years ago

Triage Stage: Design decision needed → Accepted

I'm going to accept. It does need #4986 to be applied first.

comment:3 by Simon G. <dev@…>, 17 years ago

Triage Stage: Accepted → Ready for checkin

#4986 is in, so I'm promoting this.

comment:4 by Malcolm Tredinnick, 17 years ago

Resolution: → fixed
Status: new → closed

(In [6174]) Fixed #4951 -- Improved host retrieval in sites.models.RequestSite. Thanks, Caleb.

Note: See TracTickets for help on using tickets.
Back to Top