Code

Opened 7 years ago

Closed 7 years ago

#4951 closed (fixed)

sites.RequestSite incorrectly reports domain

Reported by: Caleb Owned by: nobody
Component: Contrib apps Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If you run the development server then sites.RequestSite does not include the port number in the domain. This patch seems to fix the problem.

Attachments (1)

models.diff (684 bytes) - added by Caleb <jtxx000@…> 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by Caleb <jtxx000@…>

comment:1 Changed 7 years ago by SmileyChris

  • Component changed from Uncategorized to Contrib apps
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from jacob to adrian
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

I did wonder at why it was using SERVER_NAME over the get_host method. Not sure if it is by choice or not.

comment:2 Changed 7 years ago by SmileyChris

  • Triage Stage changed from Design decision needed to Accepted

I'm going to accept. It does need #4986 to be applied first.

comment:3 Changed 7 years ago by Simon G. <dev@…>

  • Triage Stage changed from Accepted to Ready for checkin

#4986 is in, so I'm promoting this.

comment:4 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6174]) Fixed #4951 -- Improved host retrieval in sites.models.RequestSite. Thanks, Caleb.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.