Code

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#4883 closed (duplicate)

URL reversing can't reverse URLs with plus sign

Reported by: Alexander Solovyov <alexander.solovyov@…> Owned by: adrian
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I have an URL with plus sign inside it:

url(r'^member/\+new/$', views.member_new, name="member_new")

If I use {% url %} tag, it gives me "/member/\+new/", which is unusable.

Attachments (1)

django-plus-sign-fix.patch (642 bytes) - added by andresj 6 years ago.
Fix for the plus sign problem. (Generated with svn diff) It also fixes a similar problem with dots.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to duplicate
  • Status changed from new to closed

This will be fixed by #2977, which I'm in the process of reviewing.

comment:2 Changed 6 years ago by andresj

  • Resolution duplicate deleted
  • Status changed from closed to reopened

I am opening this ticket again because #2977 hasn't been changed in a month and was created a year ago, and it seems that the patch supplied there doesn't work (my decision might be incorrect--this is my first contribution/appearence in this trac site).

I have the same problem as Alexander Solovyov in a website using many plus signs in the URLs.

I am going to attach the fix in a couple of seconds :).

Changed 6 years ago by andresj

Fix for the plus sign problem. (Generated with svn diff) It also fixes a similar problem with dots.

comment:3 follow-up: Changed 6 years ago by mtredinnick

  • Resolution set to duplicate
  • Status changed from reopened to closed

If we say we're going to close a ticket as part of another fix, then please don't reopen the original. You're welcome to attach your patch for somebody else who might find this in a search, but we're trying to reduce the number of open tickets, not have more semi-duplicates open.

comment:4 in reply to: ↑ 3 ; follow-up: Changed 6 years ago by andresj

Replying to mtredinnick:

If we say we're going to close a ticket as part of another fix, then please don't reopen the original. You're welcome to attach your patch for somebody else who might find this in a search, but we're trying to reduce the number of open tickets, not have more semi-duplicates open.

should I attach this patch I just posted to #2977 ?

comment:5 Changed 6 years ago by andresj

  • Has patch set

comment:6 in reply to: ↑ 4 Changed 6 years ago by andresj

Replying to andresj:

Replying to mtredinnick:

If we say we're going to close a ticket as part of another fix, then please don't reopen the original. You're welcome to attach your patch for somebody else who might find this in a search, but we're trying to reduce the number of open tickets, not have more semi-duplicates open.

should I attach this patch I just posted to #2977 ?

Well I guess I'll just attach it there... (sorry if I'm too impatient)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.