Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#4883 closed (duplicate)

URL reversing can't reverse URLs with plus sign

Reported by: Alexander Solovyov <alexander.solovyov@…> Owned by: Adrian Holovaty
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I have an URL with plus sign inside it:

url(r'^member/\+new/$', views.member_new, name="member_new")

If I use {% url %} tag, it gives me "/member/\+new/", which is unusable.

Attachments (1)

django-plus-sign-fix.patch (642 bytes) - added by Andres Riofrio 9 years ago.
Fix for the plus sign problem. (Generated with svn diff) It also fixes a similar problem with dots.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by Malcolm Tredinnick

Resolution: duplicate
Status: newclosed

This will be fixed by #2977, which I'm in the process of reviewing.

comment:2 Changed 9 years ago by Andres Riofrio

Resolution: duplicate
Status: closedreopened

I am opening this ticket again because #2977 hasn't been changed in a month and was created a year ago, and it seems that the patch supplied there doesn't work (my decision might be incorrect--this is my first contribution/appearence in this trac site).

I have the same problem as Alexander Solovyov in a website using many plus signs in the URLs.

I am going to attach the fix in a couple of seconds :).

Changed 9 years ago by Andres Riofrio

Attachment: django-plus-sign-fix.patch added

Fix for the plus sign problem. (Generated with svn diff) It also fixes a similar problem with dots.

comment:3 Changed 9 years ago by Malcolm Tredinnick

Resolution: duplicate
Status: reopenedclosed

If we say we're going to close a ticket as part of another fix, then please don't reopen the original. You're welcome to attach your patch for somebody else who might find this in a search, but we're trying to reduce the number of open tickets, not have more semi-duplicates open.

comment:4 in reply to:  3 ; Changed 9 years ago by Andres Riofrio

Replying to mtredinnick:

If we say we're going to close a ticket as part of another fix, then please don't reopen the original. You're welcome to attach your patch for somebody else who might find this in a search, but we're trying to reduce the number of open tickets, not have more semi-duplicates open.

should I attach this patch I just posted to #2977 ?

comment:5 Changed 9 years ago by Andres Riofrio

Has patch: set

comment:6 in reply to:  4 Changed 9 years ago by Andres Riofrio

Replying to andresj:

Replying to mtredinnick:

If we say we're going to close a ticket as part of another fix, then please don't reopen the original. You're welcome to attach your patch for somebody else who might find this in a search, but we're trying to reduce the number of open tickets, not have more semi-duplicates open.

should I attach this patch I just posted to #2977 ?

Well I guess I'll just attach it there... (sorry if I'm too impatient)

Note: See TracTickets for help on using tickets.
Back to Top