#4883 closed (duplicate)
URL reversing can't reverse URLs with plus sign
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I have an URL with plus sign inside it:
url(r'^member/\+new/$', views.member_new, name="member_new")
If I use {% url %} tag, it gives me "/member/\+new/", which is unusable.
Attachments (1)
Change History (7)
comment:1 Changed 16 years ago by
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
comment:2 Changed 16 years ago by
| Resolution: | duplicate |
|---|---|
| Status: | closed → reopened |
I am opening this ticket again because #2977 hasn't been changed in a month and was created a year ago, and it seems that the patch supplied there doesn't work (my decision might be incorrect--this is my first contribution/appearence in this trac site).
I have the same problem as Alexander Solovyov in a website using many plus signs in the URLs.
I am going to attach the fix in a couple of seconds :).
Changed 16 years ago by
| Attachment: | django-plus-sign-fix.patch added |
|---|
Fix for the plus sign problem. (Generated with svn diff) It also fixes a similar problem with dots.
comment:3 follow-up: 4 Changed 16 years ago by
| Resolution: | → duplicate |
|---|---|
| Status: | reopened → closed |
If we say we're going to close a ticket as part of another fix, then please don't reopen the original. You're welcome to attach your patch for somebody else who might find this in a search, but we're trying to reduce the number of open tickets, not have more semi-duplicates open.
comment:4 follow-up: 6 Changed 16 years ago by
Replying to mtredinnick:
If we say we're going to close a ticket as part of another fix, then please don't reopen the original. You're welcome to attach your patch for somebody else who might find this in a search, but we're trying to reduce the number of open tickets, not have more semi-duplicates open.
should I attach this patch I just posted to #2977 ?
comment:5 Changed 16 years ago by
| Has patch: | set |
|---|
comment:6 Changed 16 years ago by
Replying to andresj:
Replying to mtredinnick:
If we say we're going to close a ticket as part of another fix, then please don't reopen the original. You're welcome to attach your patch for somebody else who might find this in a search, but we're trying to reduce the number of open tickets, not have more semi-duplicates open.
should I attach this patch I just posted to #2977 ?
Well I guess I'll just attach it there... (sorry if I'm too impatient)
This will be fixed by #2977, which I'm in the process of reviewing.