Enforce a check for duplicate named url patterns

[Favo <favo@…>]

The current naming url pattern don't check the duplication naming. As it said in documentatioin,

Note

When you name your URL patterns, make sure you use names that are unlikely to clash with any other application’s choice of names. If you call your URL pattern comment, and another application does the same thing, there’s no guarantee which URL will be inserted into your template when you use this name.

Putting a prefix on your URL names, perhaps derived from the application name, will decrease the chances of collision. We recommend something like myapp-comment instead of comment.

I think it's quite easy to check the duplication naming url pattern in the construction stage and should be.

[Simon G. <dev@…>]

Want to write up a patch to do this check?

[raminf]

Checking for duplicate URL names (if specified)

[Russell Keith-Magee]

This is good idea in principle, but the patch doesn't really fix the problem. If you have multiple urls.py files, this approach won't identify duplicates across the files.

On a housekeeping note - Django uses 4 spaces, not tabs, for indentation.

[drdee]

New patch to check for duplicate urlnames

[drdee]

Hi,

I have taken the liberty to come up with a new patch to check for duplicate urlnames across different apps (but in the same project). This function loads the different urls.py file, constructs a list of urlnames and raises an ImproperlyConfigured error when it finds a duplicate name. The call to this function is missing because I do not think it should be part of patterns() like the previous patch: that would create too many unnecessary calls to the function. IMHO, it's better to put a call to this function around model initialization, but I do not know what would be an appropriate place to do that, so I leave that decision to the senior django developers. I can also imagine that this function needs to move to a different location then the current /django/conf/urls/defaults.py but for the sake of the ticket I have left it in the same place as the previous patch.

Best,

Diederik

[Chris Beaven]

Having duplicate url names is fine in cases where you use different arguments (and it resolves them correctly based on the arguments passed).

For the case where a named argument is overriding an existing name (with exactly the same arguments), this is a case already documented to "not do":

When you name your URL patterns, make sure you use names that are unlikely to clash with any other application's choice of names. If you call your URL pattern comment, and another application does the same thing, there's no guarantee which URL will be inserted into your template when you use this name.

[Jacob]

Milestone 1.3 deleted