Ticket #4824: duplicate_urlnames.diff

trunk_patched/django/conf/urls/defaults.py

@@ +1 @@
+import sys
+fromd django.conf import settings
 from django.core.urlresolvers import RegexURLPattern, RegexURLResolver
 from django.core.exceptions import ImproperlyConfigured
 
@@ -6 +8 @@
 handler404 = 'django.views.defaults.page_not_found'
 handler500 = 'django.views.defaults.server_error'
 
+def _detect_duplicate_urlnames():
+    '''
+    This function loads for each installed app the associated url file, it assumes that this this file is in the root
+    of a project. Then it constructs a list of all urlnames and if it finds a duplicate urlname will raise an ImproperlyConfigured error
+    '''
+    urlnames = []
+    for app in settings.INSTALLED_APPS:
+        urlconf = app + '.urls'
+        try:
+            # Not all apps will necesarrily have a urls file, hence the try / except clause
+            __import__(urlconf)
+            urls = []
+            urls.append(sys.modules[urlconf])
+            for url in urls:
+                for pattern in url.urlpatterns:
+                    name = getattr(pattern, 'name')
+                    if name == None:
+                        continue
+                    elif name not in urlnames:
+                        urlnames.append(name)
+                    else:
+                        raise ImproperlyConfigured('Duplicate named URL specified ("%s")' % name) 
+        except ImportError:
+            pass
+
 def include(arg, namespace=None, app_name=None):
     if isinstance(arg, tuple):
         # callable returning a namespace hint