Opened 8 years ago

Closed 5 years ago

#4748 closed (wontfix)

contrib.auth: Increase length of names of permissions

Reported by: Thomas Güttler <hv@…> Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords: dbchange
Cc: remco@…, hv@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: UI/UX:

Description

Hi,

here is a small patch to increase the length of permission names. We
hit 53 characters. 100 should be save.

Attachments (1)

models_py.diff (565 bytes) - added by Thomas Güttler <hv@…> 8 years ago.

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by Thomas Güttler <hv@…>

comment:1 Changed 8 years ago by Thomas Güttler <hv@…>

  • Component changed from Uncategorized to Admin interface
  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from jacob to adrian
  • Patch needs improvement unset

comment:2 Changed 8 years ago by adrian

This is technically a backwards-incompatible change to the database table layout, so if we do this, we'll have to provide instructions for people to convert their tables.

comment:3 Changed 8 years ago by Simon G. <dev@…>

  • Summary changed from contrib/auth: Increase length of names of permissions to contrib.auth: Increase length of names of permissions
  • Triage Stage changed from Unreviewed to Design decision needed

comment:4 Changed 8 years ago by ubernostrum

#4129 was a duplicate, but also has a patch.

comment:5 Changed 8 years ago by remco@…

  • Cc remco@… added

comment:6 Changed 8 years ago by jacob

  • Keywords dbchange added
  • Triage Stage changed from Design decision needed to Accepted

comment:7 Changed 7 years ago by guettli

  • Cc hv@… added

comment:8 Changed 7 years ago by guettli

If you don't want to modify django code, you can use a post_syncdb signal hook.

I created a django snippet, to increase the length after syndb is run:

http://www.djangosnippets.org/snippets/718/

comment:10 Changed 5 years ago by adamnelson

  • Needs tests set
  • Patch needs improvement set
  • Triage Stage changed from Accepted to Ready for checkin

Test should be updated with 50+ character permission name

comment:11 Changed 5 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from new to closed

This would cause problems for every single existing installation of this application (since the underlying database would need to be changed). Changing model field constraints is only to be done if no other option is available. In this case, we're not at that point yet.

Note: See TracTickets for help on using tickets.
Back to Top