Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4649 closed (invalid)

"per-view cache" and decorator syntax.

Reported by: anonymous Owned by: jacob
Component: Documentation Version: master
Severity: Keywords: cache_page, decorator
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The docu about the "per-view cache" syntax seems to be wrong: http://www.djangoproject.com/documentation/cache/#the-per-view-cache

Malcolm Tredinnick writes about the "cache_page" here: http://groups.google.com/group/django-users/msg/581a32c198e6ae07

So, "@cache_page" can't get parameters.

The alternative non-decorator syntax seems wrong, too. Look at 4421

Attachments (0)

Change History (5)

comment:1 follow-up: Changed 7 years ago by Gary Wilson <gary.wilson@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

The documentation is correct, it's the code that's wrong. See #1015.

comment:2 in reply to: ↑ 1 Changed 7 years ago by anonymous

  • Resolution invalid deleted
  • Status changed from closed to reopened

Replying to Gary Wilson <gary.wilson@gmail.com>:

The documentation is correct, it's the code that's wrong. See #1015.

IMHO until #1015 is fixed/checked in, the docu should display the way it works *now*. Many users run directly into the "Bug". That's not the best way...

comment:3 Changed 7 years ago by mtredinnick

  • Resolution set to invalid
  • Status changed from reopened to closed

If we're going to fix something, fixing the real problem is the right thing to do. Gary is right; the real bug here is #1015. Please don't reopen this.

comment:4 Changed 7 years ago by anonymous

Oh. Nice philosophy. :( We have a "like it should run" Documentation, without a note that this syntax dosn't work until a bug is fixed.

comment:5 Changed 7 years ago by SmileyChris

I kinda agree with anonymous. That ticket has a patch two months old, and since it's not that critical it could sit there for much longer. Well maybe not in this case, now it has got some attention.

Documentation should be kept up to date even if there is a bug - it's easy to update it again when the main ticket fixed.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.