Opened 17 years ago
Closed 17 years ago
#4418 closed (fixed)
Add media descriptions to newforms widgets
Reported by: | Russell Keith-Magee | Owned by: | Russell Keith-Magee |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | media css javascript | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | yes |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
A newforms widget currently defines the way to render a user interface input element. However, in order to make interesting input elements, you also need other media - i.e., Javascript and CSS. These requirements can be defined on a per-widget basis (a Date field requires a Calendar widget; the calendar widget requires media/calendar.js and media/calendar.css).
At present, there is no easy way to:
- identify what media is required to display a form
- identify and eliminate any duplicate media requirements, e.g., a base css file required by two different widgets on a form.
newforms-admin has some hand rolled functionality to determine Javascript requirements for a page. This ticket describes a more general solution that could be applied to any widget, and therefore to any form.
It involves adding a meta-class to Widget that processes a 'Media' inner class; this inner class is turned into a 'Media' object. Media objects can be printed (yielding <link> and <script> statements). Media objects can also be added, so media from one widget can be added to another widget, yielding the union of required media.
Forms are also modified; you can interrogate form.media to find out the union of all CSS and JavaScript required by a given form.
Discussed in detail here:
http://groups.google.com/group/django-developers/browse_thread/thread/58fc9cab819c08b9/af54bb9c638fede7#af54bb9c638fede7
Attachments (5)
Change History (8)
by , 17 years ago
Attachment: | media.diff added |
---|
comment:1 by , 17 years ago
Owner: | changed from | to
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 17 years ago
Has patch: | set |
---|---|
Needs documentation: | set |
by , 17 years ago
Attachment: | media2.diff added |
---|
Revised media patch, to address inheritance issues.
by , 17 years ago
Attachment: | newforms-admin-media.diff added |
---|
Media descriptors for newforms-admin; against [5636]
by , 17 years ago
Attachment: | newforms-admin-media.5651.diff added |
---|
Improved media descriptors for newforms-admin; against [5651]
comment:3 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Adds a Media descriptor to newforms widgets