Opened 11 years ago

Closed 11 years ago

#4267 closed (fixed)

a bug in "The Django template language: For Python programmers"

Reported by: keisuke.nishida@… Owned by: Jacob
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


I have found a possible bug in the following page:

You refer to "token.contents[0]" at several places in the sample code like this:

def do_current_time(parser, token):
        # split_contents() knows not to split quoted strings.
        tag_name, format_string = token.split_contents()
    except ValueError:
        raise template.TemplateSyntaxError, "%r tag requires a single argument" % token.contents[0]

I believe "token.contents[0]" returns a single character, which is not very informative
and not what you want here. Maybe it should have been "token.contents.split()[0]"?

The same applies to 0.95/0.96 docs.

Best regards,

Change History (1)

comment:1 Changed 11 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [5188]) Fixed #4267 -- In example code, extract the template tag name correctly in
error messages where Token.split_contents() has failed. Thanks,

Note: See TracTickets for help on using tickets.
Back to Top