#4266 closed (fixed)
[unicode] str2smart_str
Reported by: | Owned by: | Malcolm Tredinnick | |
---|---|---|---|
Component: | Uncategorized | Version: | dev |
Severity: | Keywords: | unicode admin | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Hi,
here is a small patch to django/contrib/admin/templatetags/admin_list.py
Attachments (1)
Change History (5)
by , 18 years ago
Attachment: | admin_list_smart_str.diff added |
---|
comment:1 by , 18 years ago
Owner: | changed from | to
---|---|
Summary: | unicode branch: str2smart_str → [unicode] str2smart_str |
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 18 years ago
comment:3 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Thomas: what would be an example of how to test this change? In other words, if I don't apply the patch, what is a way to cause the admin interface to break? I can't immediately work out how to execute that piece of code.
I have a feeling it's not fixing the real cause of the problem, because
html.escape()
is already calling smart_unicode() on its input. So I suspect the solution might be to remove the str() call altogether on that line and just useescape(field_val)
.