Opened 8 years ago

Closed 8 years ago

#4258 closed (fixed)

[newforms-admin] Models aren't grouped by application on index page

Reported by: Matthias Pronk <django@…> Owned by: adrian
Component: contrib.admin Version: newforms-admin
Severity: Keywords: newforms-admin
Cc: jm.bugtracking@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The newforms-admin doesn't group the models per application.

Attached patch fixes this.

Attachments (1)

admin-index.diff (1.5 KB) - added by Matthias Pronk <django@…> 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Matthias Pronk <django@…>

comment:1 Changed 8 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from other branch to newforms branch

comment:2 Changed 8 years ago by anonymous

  • Cc jm.bugtracking@… added

comment:3 follow-up: Changed 8 years ago by mtredinnick

There's also an alternative patch in #4477. I haven't made any attempt to work out if one is slightly better than the other; both seem reasonable.

comment:4 in reply to: ↑ 3 Changed 8 years ago by django@…

Replying to mtredinnick:

There's also an alternative patch in #4477. I haven't made any attempt to work out if one is slightly better than the other; both seem reasonable.

I didn't know about 'django.utils.datastructures.SortedDict', which seems to be a slightly more elegant way of doing it.
So I would suggest using the patch in #4477.

comment:5 Changed 8 years ago by adrian

  • Version changed from newforms branch to newforms-admin

comment:6 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [5441]) newforms-admin: Fixed #4258 and #4477 -- Changed admin index page to group by applications, and alphabetized things. Thanks to Matthias Pronk and Honza Kral for the patches; I ended up using a hybrid of both

Note: See TracTickets for help on using tickets.
Back to Top