Opened 9 years ago

Closed 9 years ago

#4232 closed (fixed)

Update to the newforms documentation

Reported by: heckj@… Owned by: Jacob
Component: Documentation Version: master
Severity: Keywords: newforms documentation
Cc: heckj@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In learning about how to use the newforms from within the templates, I thought I'd write it up from a template designer's point of view to make the newforms a little more accessible. I've submitted the update to the docs as a patch, attached to this bug.

Attachments (4)

newforms.diff (2.0 KB) - added by heckj@… 9 years ago.
documentation updates
newforms.2.diff (4.1 KB) - added by heckj@… 9 years ago.
documentation updates v2
4232.diff (4.2 KB) - added by heckj@… 9 years ago.
final update - cleaned up view per request and removed nasty tabs
4232.2.diff (4.2 KB) - added by heckj@… 9 years ago.
Update to the diff after checkins [5219], [5222], and [5237] (easier merge)

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by heckj@…

Attachment: newforms.diff added

documentation updates

comment:1 Changed 9 years ago by Simon G. <dev@…>

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Summary: [patch] update to the newforms documentationUpdate to the newforms documentation
Triage Stage: UnreviewedAccepted

Looks like a good start!

Changed 9 years ago by heckj@…

Attachment: newforms.2.diff added

documentation updates v2

comment:2 Changed 9 years ago by heckj@…

I added some more documentation - putting in an example view just above "Outputting to HTML" to bring together all of the components above. I also put in a few more "template" references on rendering of the form using shortcuts as_p, as_ul, and as_table.

comment:3 Changed 9 years ago by Gary Wilson <gary.wilson@…>

Patch needs improvement: set

Thanks for the documentation. Is this complete now, or are you still working on this?

A few comments:

  • It appears that you have possibly mixed some tabs in there as the indention is nonuniform.
  • In the view code, I believe it is better practice to use "if request.method == 'POST'" instead of "if request.POST".

comment:4 in reply to:  3 Changed 9 years ago by anonymous

Replying to Gary Wilson <gary.wilson@gmail.com>:

Thanks for the documentation. Is this complete now, or are you still working on this?

A few comments:

  • It appears that you have possibly mixed some tabs in there as the indention is nonuniform.
  • In the view code, I believe it is better practice to use "if request.method == 'POST'" instead of "if request.POST".

I'll clean up the tabs and change the view code per your suggestions, then I'll call it done for this set. I need to learn more about Widgets and the variety of ways of using them before I attack more docs.

Changed 9 years ago by heckj@…

Attachment: 4232.diff added

final update - cleaned up view per request and removed nasty tabs

comment:5 Changed 9 years ago by heckj@…

Added that final cleanup update. The previous diff can be deleted.

comment:6 Changed 9 years ago by Gary Wilson <gary.wilson@…>

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

Changed 9 years ago by heckj@…

Attachment: 4232.2.diff added

Update to the diff after checkins [5219], [5222], and [5237] (easier merge)

comment:7 Changed 9 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [5294]) Fixed #4232 -- Added example usages to the newforms documentation. Thanks, Joe
Heck.

Note: See TracTickets for help on using tickets.
Back to Top