Code

Opened 7 years ago

Closed 7 years ago

#4221 closed (fixed)

tutorial 4 uses hardcoded, absolute URL instead of get_absolute_url() or permalink()

Reported by: anonymous Owned by: jacob
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

Tutorial 3 makes a big deal of not using absolute urls in an application. Then tutorial 4 includes an absolute URL in views.vote :(

return HttpResponseRedirect('/polls/%s/results/' % p.id)

Shouldn't it be using something like get_absolute_url instead?

Attachments (0)

Change History (2)

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5368]) Fixed #4221 -- Removed dependence on hard-coded URL in tutorial 4.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.