Opened 16 years ago
Closed 10 years ago
#4120 closed Cleanup/optimization (fixed)
some admin Javascript cleanups
Reported by: | arvin | Owned by: | andrewjesaitis |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | javascript admin |
Cc: | andrewjesaitis | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Here are the pure javascript cleanups from ticket 4045.
Attachments (1)
Change History (14)
Changed 16 years ago by
Attachment: | admin-js.2.diff added |
---|
comment:1 Changed 16 years ago by
Component: | Uncategorized → Admin interface |
---|---|
Owner: | changed from Jacob to Adrian Holovaty |
comment:2 Changed 16 years ago by
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 Changed 15 years ago by
Owner: | changed from nobody to xian |
---|
comment:4 Changed 13 years ago by
Patch needs improvement: | set |
---|
xian obviously isn't doing anything with this. Patch needs to be updated to current js.
comment:5 Changed 13 years ago by
Owner: | changed from xian to nobody |
---|
comment:6 Changed 12 years ago by
Severity: | → Normal |
---|---|
Type: | → Cleanup/optimization |
comment:9 Changed 10 years ago by
Cc: | andrewjesaitis added |
---|---|
Owner: | changed from nobody to andrewjesaitis |
Status: | new → assigned |
This was quite an old ticket, but most of the original patch still applies. Consider it spring cleaning?!
It is just js cleanup. No admin functionality. The most import change is that it removes a duplicative function from calendar.js, which is also found in core.js.
The other two commits shuffle a couple functions into core.js. This ticket seemed to be a prerequisite to addressing #4045 which I will pick up once a call is made on this ticket.
The only part of the original patch that didn't apply were the changes to js/admin/ordering.js, which appears to have been removed. This change looked to be removing a duplicative function as well.
The associated pull request -- https://github.com/django/django/pull/948
comment:10 Changed 10 years ago by
Patch needs improvement: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Looks good to me, I don't think any of these is subject to the backwards compatibility policy.
comment:13 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Reassigning to xian since he's doing admin JS stuff.