Opened 8 years ago

Closed 8 years ago

#4101 closed (fixed)

Confusing URL match in generic views examples

Reported by: Collin Grady <cgrady@…> Owned by: jacob
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

On http://www.djangoproject.com/documentation/generic_views/ there's a URL match using r'/?$' which could cause confusion to new users - as the preceding slash is never sent to urlpatterns, that /? is completely extraneous, but may make people think that sometimes it is sent.

Attachments (2)

generic_views.patch (838 bytes) - added by Collin Grady <cgrady@…> 8 years ago.
generic_views.2.patch (840 bytes) - added by Collin Grady <cgrady@…> 8 years ago.
minor correction to last patch

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Collin Grady <cgrady@…>

Changed 8 years ago by Collin Grady <cgrady@…>

minor correction to last patch

comment:1 Changed 8 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

What do you mean confusing to "new users"? I had to think about this for a little while to work out what it might be doing. I agree, it's worth fixing.

comment:2 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5050]) Fixed #4101 -- Clarified a potentially confusing URL pattern in one example.
Thanks, Collin Grady.

Note: See TracTickets for help on using tickets.
Back to Top