Patch to Output Timezone in Date Fields for Atom Feeds

[Alastair Tse <alastair@…>]

Currently, django.utils.feedgenerator outputs date strings for Atom 1.0 feeds without timezone information. For datetime objects that have tzinfo infor set, we should output the UTC offset if present. The patch attach will simply check whether tzinfo is set to something other than None, and thus have a valid timezone UTF offset that can be shown via strftime().

[Thomas Kerpe]

Looks reasonable OK for me...

[Thomas Kerpe]

Fixed in [6233]

[max klymyshyn]

I don't understand what is wrong, but i had some trouble with django/utils/feedgenerator.py.
Error output is:

Exception Value:  	'datetime.date' object has no attribute 'tzinfo'
Exception Location: /Users/gabonsky/Bin/dist/django/django/utils/feedgenerator.py in rfc2822_date, line 29
Python Executable:  /System/Library/Frameworks/Python.framework/Versions/2.5/Resources/Python.app/Contents/MacOS/Python
Python Version: 	2.5.1

Here is patch for django/django/utils/feedgenerator.py:

29c29
<     if date.tzinfo:
---
>     if hasattr(date, 'tzinfo') and date.tzinfo:

[anonymous]

Same problem here:

Code:

def items(self):
    return Entry.objects.filter(is_published=True, pub_date__lte=datetime.date.today()).order_by('-pub_date')[:5]

Error:

Exception Type: AttributeError
Exception Value: 'datetime.date' object has no attribute 'tzinfo'
Exception Location: /Library/Python/2.6/site-packages/django/contrib/syndication/feeds.py in get_feed, line 148
Python Executable: /usr/bin/python
Python Version: 2.6.1

[wiboshu]

Replying to anonymous:

Same problem here:

Code:

def items(self):
    return Entry.objects.filter(is_published=True, pub_date__lte=datetime.date.today()).order_by('-pub_date')[:5]

Error:

Exception Type: AttributeError
Exception Value: 'datetime.date' object has no attribute 'tzinfo'
Exception Location: /Library/Python/2.6/site-packages/django/contrib/syndication/feeds.py in get_feed, line 148
Python Executable: /usr/bin/python
Python Version: 2.6.1

You may have used DateField in the model incorrectly.Use DateTimeField instead.

[Aymeric Augustin]

As mentioned by wiboshu, you're using a DateField for pub_date, rather than a DateTimeField.

There's no reason to reject dates here. Indeed, it was a regression introduced in r6233. However, it was fixed as a side effect of #15503.

I'm going to add tests.

Please reopen if you still encounter the issue, with enough information to reproduce it.

[Aymeric Augustin]

In [16989]:

Ensured that the feeds framework supports both datetimes and dates. Refs #4076.