Opened 9 years ago

Closed 9 years ago

#3986 closed (fixed)

Add Indian Localflavour

Reported by: pradeep.gowda@… Owned by: Adrian Holovaty
Component: contrib.localflavor Version: master
Severity: Keywords: localflavor, l10n, in, ind
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

Patch to add a module to django.contrib.localflavor for India: INStateSelect and INZipCodeField.

note: The directory name is ind instead of two letter in as it conflicts with python keyword in.

Attachments (2)

indianlocalflavour.diff (4.3 KB) - added by pradeep.gowda@… 9 years ago.
initial diff file attached.
in_localflavor.diff (4.3 KB) - added by Simon G. <dev@…> 9 years ago.
renamed ind/ to in_/ in the original patch to comply with PEP8

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by pradeep.gowda@…

Attachment: indianlocalflavour.diff added

initial diff file attached.

comment:1 Changed 9 years ago by Simon G. <dev@…>

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 9 years ago by Russell Keith-Magee

Needs tests: set
Patch needs improvement: set

To comply with PEP8, the name of this module should be 'in_', not 'ind'.

comment:3 Changed 9 years ago by Russell Keith-Magee

Triage Stage: Ready for checkinAccepted

Changed 9 years ago by Simon G. <dev@…>

Attachment: in_localflavor.diff added

renamed ind/ to in_/ in the original patch to comply with PEP8

comment:4 Changed 9 years ago by Simon G. <dev@…>

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:5 Changed 9 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [5847]) Fixed #3986 -- Added Indian localflavor. Thanks, pradeep.gowda@….

comment:6 Changed 9 years ago by C8E

Resolution: fixed
Status: closedreopened

Malcolm, you did apply the patch in django/contrib/in_ , not in django/contrib/localflavor/in_ . Is that intentional?

comment:7 Changed 9 years ago by Malcolm Tredinnick

Nope, not intentional. I screwed up. :-(

Good catch. I'll fix it.

comment:8 Changed 9 years ago by Malcolm Tredinnick

Resolution: fixed
Status: reopenedclosed

(In [5856]) Moved in_ directory to its correct location under localflavor. I committed it in the wrong place in [5847]. Fixed #3986.

comment:9 Changed 9 years ago by Simon G. <dev@…>

Resolution: fixed
Status: closedreopened

My fault sorry - should have updated the patch to the right dir. Malcolm - the in_ dir. is still in django/contrib/ but empty. Can this be removed?

comment:10 Changed 9 years ago by Simon G. <dev@…>

Resolution: fixed
Status: reopenedclosed

Already well ahead of me - fixed in [5879]

Note: See TracTickets for help on using tickets.
Back to Top