app name incorrectly reported in syncdb output

[kbussell@…]

in syncdb(), the app_name variable isn't set in custom SQL installation loop, which can cause incorrect status messages.

[Malcolm Tredinnick]

Under what circumstances does this fail? Can you describe a simple example?

[kbussell@…]

Replying to mtredinnick:

Under what circumstances does this fail? Can you describe a simple example?

Sorry about the terseness of the original message. It was such a simple fix, I didn't go into much detail. Apologies.

The output is incorrect whenever a custom SQL file exists for an application which isn't the last one listed in INSTALLED_APPS. Try creating a site with two apps, and create an sql file for the first one in the INSTALLED_APPS list. You'll see the output from syncdb shows the application name of the second app instead of the first.

It's easiest to see by just looking at the code--in the syncdb function, there are several loops through models.get_apps(). The first line after all but one sets the app_name variable to the current application name for use in print statements. The loop for installing custom SQL uses the app_name variable, but never updates it.

[Vinay Sajip <vinay_sajip@…>]

I've confirmed that this happens, and that the error messages refer to the wrong app (the last app in INSTALLED_APPS). With the patch applied, the correct app name is used. I think this is ready for check-in.

[Vinay Sajip <vinay_sajip@…>]

Path now relative to root directory

[Malcolm Tredinnick]

(In [5131]) Fixed #3905 -- Report app_name correctly in errors during custom SQL
installation. Thanks, kbussell@….