Opened 17 years ago
Closed 13 years ago
#3884 closed Uncategorized (wontfix)
humanize filter `intcomma` should be renamed to `numcomma`
| Reported by: | Chris Beaven | Owned by: | Adrian Holovaty |
|---|---|---|---|
| Component: | Contrib apps | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | lidaobing@… | Triage Stage: | Design decision needed |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
The current filter name doesn't give it justice (it also comma separates floats).
Backwards compatibility is easy, and it'd be good to provide a documentation example of it handling a float.
#3017 was the inspiration for this ticket.
Change History (5)
comment:1 by , 17 years ago
| Triage Stage: | Unreviewed → Design decision needed |
|---|
comment:2 by , 17 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
I'm not necessarily against renaming the filter, but I don't think commaseparate is a great name because of the tendency for people to misspell "separate". Reopen with another name if you can think of one.
comment:3 by , 16 years ago
| Cc: | added |
|---|
comment:4 by , 13 years ago
| Easy pickings: | set |
|---|---|
| Resolution: | wontfix |
| Severity: | → Normal |
| Status: | closed → reopened |
| Summary: | humanize filter `intcomma` should be renamed to `commaseparate` → humanize filter `intcomma` should be renamed to `numcomma` |
| Type: | → Uncategorized |
How about "numcomma"
comment:5 by , 13 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | reopened → closed |
At this point in Django's life, I'm not sure I see the value in changing the name. It might not be the most accurate name in the world, but it isn't fundamentally broken, and changing it would require a whole bunch of deprecation/backwards compatibility dancing for what is, at the end of the day, not a whole lot of gain.
If the name change was required in the context of some clarification of what intcomma actually does, I might be convinced, but if were doing it just for the sake of theoretical purity, I think we can pass.
What does core think?